Camera -> Bugfix

[antibyte]

Now as people start to overclock their poor Spica i thought it is
time to fix the camera bug, as it is no good idea to have it run
overclocked at full speed all the time after using the camera.

Add / Change the following in "s3c_camera_driver.c"

#include <linux/cpufreq.h>


void s3c_camif_unregister_sensor(camif_cis_t *cis)
{
__TRACE_CAMERA_DRV(printk("[CAM-DRV] +s3c_camif_unregister_sensor\n"));

cis->init_sensor = 0;

__TRACE_CAMERA_DRV(printk("[CAM-DRV] -s3c_camif_unregister_sensor\n"));

/*-------------------------------------------------------------*/
/* antibyte - little hack to restore the conservative governor */
int ret = cpufreq_set_policy(0, "conservative ");
printk("[CAM-DRV] set conservative cpufreq governor : %s\n", ret ? "failed":"ok");
/*-------------------------------------------------------------*/
}

[Pizzmaker]

Wow! cool antibyte! is it work for you?
How about dark camera at start bug fix also? Is this possible?

[golecpch]

Wouldn't it be better to (for example while turning on camera, in driver) save somewhere present governor and restore, it rather than setting it to conservative??

[islam_ashraf]

wat is the wrong with the camera sombody tell me :?

[Fulkerson]

Would be better to set it to whatever governor it was running before than conservative...

[antibyte]

Wouldn't it be better to (for example while turning on camera, in driver) save somewhere present governor and restore, it rather than setting it to conservative??

Its just a quick hack, i thought about that too but was too lazy to figure out if the gouvernor is changed in the driver.
I think it is changed in Androids Framework.

---------- Post added at 10:59 PM ---------- Previous post was at 10:56 PM ----------

wat is the wrong with the camera sombody tell me :?

After using the camera the cpu is stuck at 800 MHz and never goes back to powersaving lower frequencies until reboot.

[SOLOVEY]

Аntibyte,
Thanks, I waited for it

[islam_ashraf]

Its just a quick hack, i thought about that too but was too lazy to figure out if the gouvernor is changed in the driver.
I think it is changed in Androids Framework.

---------- Post added at 10:59 PM ---------- Previous post was at 10:56 PM ----------



After using the camera the cpu is stuck at 800 MHz and never goes back to powersaving lower frequencies until reboot.

aah thanks alot ^^

[golecpch]

Its just a quick hack, i thought about that too but was too lazy to figure out if the gouvernor is changed in the driver.
I think it is changed in Androids Framework.

If we would build eclair from source, will it have working camera?? If yes, we could check there for this bug. If it is in framework, we shouldn't have bug, if not, it could be code in driver or some kind of camera library (according to Camera | Android Open Source ).

[Pizzmaker]

wat is the wrong with the camera sombody tell me :?

When you by a spica?
There is two bugs - dark camera at start and 800 mhz saving after close. But some new phones is not have this bugs... Am look prorerly worked camera on my friend's new phone